From bb093cdefe3d1d6831c051f925df14553d3b7027 Mon Sep 17 00:00:00 2001 From: EinTim23 Date: Wed, 20 Nov 2024 16:44:21 +0100 Subject: [PATCH] fix process detection on newer windows 11 builds --- src/backends/windows.cpp | 66 ++++++++++++++++++++++++++++++++++++++-- 1 file changed, 64 insertions(+), 2 deletions(-) diff --git a/src/backends/windows.cpp b/src/backends/windows.cpp index cef49e2..de5a900 100644 --- a/src/backends/windows.cpp +++ b/src/backends/windows.cpp @@ -1,8 +1,10 @@ #ifdef _WIN32 #define WIN32_LEAN_AND_MEAN #include +#include #include #include +#include #include #include #include @@ -26,6 +28,58 @@ std::string toStdString(winrt::hstring in) { return converter.to_bytes(in.c_str()); } +std::string getAppModelIdOfProcess(HANDLE hProc) { + UINT32 length = 0; + LONG rc = GetApplicationUserModelId(hProc, &length, NULL); + if (rc != ERROR_INSUFFICIENT_BUFFER) + return ""; + + PWSTR fullName = (PWSTR)malloc(length * sizeof(*fullName)); + if (!fullName) + return ""; + + rc = GetApplicationUserModelId(hProc, &length, fullName); + if (rc != ERROR_SUCCESS) { + free(fullName); + return ""; + } + std::string name = toStdString(fullName); + free(fullName); + return name; +} + +std::string getProcessNameFromAppModelId(std::string appModelId) { + DWORD processes[1024]; + DWORD cbNeeded; + + if (!EnumProcesses(processes, sizeof(processes), &cbNeeded)) + return ""; + + unsigned int processCount = cbNeeded / sizeof(DWORD); + + for (DWORD i = 0; i < processCount; i++) { + DWORD processID = processes[i]; + + HANDLE hProcess = OpenProcess(PROCESS_QUERY_LIMITED_INFORMATION, FALSE, processID); + if (hProcess) { + std::string modelid = getAppModelIdOfProcess(hProcess); + + if (modelid != appModelId) { + CloseHandle(hProcess); + continue; + } + + char exeName[MAX_PATH]{}; + DWORD size = MAX_PATH; + QueryFullProcessImageNameA(hProcess, 0, exeName, &size); + std::filesystem::path exePath = exeName; + CloseHandle(hProcess); + return exePath.filename().string(); + } + } + return ""; +} + bool CreateShortcut(std::string source, std::string target) { CoInitialize(nullptr); WCHAR src[MAX_PATH]; @@ -121,10 +175,18 @@ std::shared_ptr backend::getMediaInformation() { utils::trim(albumName); } + std::string modelId = toStdString(currentSession.SourceAppUserModelId()); + + // I do know that this is disgusting, but for some reason microsoft decided to switch out the exe name with the + // ApplicationUserModelId in some version of windows 11. So we check if it's an exe name, if not we are on some + // newer windows version and need to get the exe name from the model id. We cannot directly work with the model id + // because it's unique per machine and therefore would mess up configs with preconfigured apps. + if (modelId.find(".exe") == std::string::npos) + modelId = getProcessNameFromAppModelId(modelId); + return std::make_shared( playbackInfo.PlaybackStatus() == GlobalSystemMediaTransportControlsSessionPlaybackStatus::Paused, - toStdString(mediaProperties.Title()), artist, albumName, toStdString(currentSession.SourceAppUserModelId()), - thumbnailData, endTime, elapsedTime); + toStdString(mediaProperties.Title()), artist, albumName, modelId, thumbnailData, endTime, elapsedTime); } bool backend::init() {